database: Remove Partitions from our tables (#8489) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahead of the move from ProxySQL + MariaDB to Vitess + MySQL 8 in letsencrypt#8468. Vitess blocks partition related DDL, so partitions need to be removed from all schemas under `sa/db*`. The team has agreed that this drift from Production is acceptable because it lets us begin testing on Vitess and MySQL sooner. Separately, `thisUpdate` and `nextUpdate` were relying on an implicit `DEFAULT NULL`. We now make that explicit, matching how we define other DATETIME columns. Also, add a missing `DROP TABLE `incidents`;` to our combined schema migration. Part of letsencrypt#7736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahead of the move from ProxySQL + MariaDB to Vitess + MySQL 8 in letsencrypt#8468. Vitess blocks partition related DDL, so partitions need to be removed from all schemas under
sa/db*. The team has agreed that this drift from Production is acceptable because it lets us begin testing on Vitess and MySQL sooner.Separately,
thisUpdateandnextUpdatewere relying on an implicitDEFAULT NULL. We now make that explicit, matching how we define other DATETIME columns. Also, add a missingDROP TABLEincidents;to our combined schema migration.Part of letsencrypt#7736